Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDPCP-11100 Async resource creation #77

Merged
merged 1 commit into from
Feb 7, 2024
Merged

CDPCP-11100 Async resource creation #77

merged 1 commit into from
Feb 7, 2024

Conversation

daszabo
Copy link
Contributor

@daszabo daszabo commented Jan 29, 2024

No description provided.

@daszabo daszabo requested a review from a team as a code owner January 29, 2024 16:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

Go test coverage: 31.8% for commit f840cd5
⚠️ 2 of 9 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/iam
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages 
# Package Name                                                      | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest             |    28.0%
+ github.com/cloudera/terraform-provider-cdp/provider               |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub      |    27.0%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake     |     2.7%
+ github.com/cloudera/terraform-provider-cdp/resources/environments |    46.4%
- github.com/cloudera/terraform-provider-cdp/resources/iam          |     0.0%
- github.com/cloudera/terraform-provider-cdp/resources/ml           |     0.0%
+ github.com/cloudera/terraform-provider-cdp/utils                  |    45.7%
+ github.com/cloudera/terraform-provider-cdp/utils/test             |    80.0%

@daszabo daszabo changed the title CDPCP-11068 Flexible server support CDPCP-11100 Async resource creation Feb 1, 2024
balazsgaspar
balazsgaspar approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@balazsgaspar balazsgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Let's make sure we call aysnc creation of environment and datalake resources an experimental feature for now. (Highlighting this in the release notes.)

@daszabo daszabo requested a review from gregito February 6, 2024 14:04
@gregito gregito enabled auto-merge (rebase) February 7, 2024 08:56
@gregito gregito merged commit 5f1b975 into main Feb 7, 2024
6 checks passed
@gregito gregito deleted the CDPCP-11100 branch February 7, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balazsgaspar balazsgaspar balazsgaspar approved these changes

@gregito gregito gregito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daszabo @gregito @balazsgaspar